-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fix trafo3w tap at star point #2411
bug fix trafo3w tap at star point #2411
Conversation
…: fix test_contingency.py for updated ls2g version
…to fix/trafo3w_tap_at_starpoint
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2411 +/- ##
========================================
Coverage 75.98% 75.98%
========================================
Files 282 282
Lines 32962 32963 +1
========================================
+ Hits 25047 25048 +1
Misses 7915 7915 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, the changes for the consideration of neutral step position look fine for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed the changes and looks good
trafo3w tap at star point worked only if tap_neutral was 0. This PR fixes this issue