Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix trafo3w tap at star point #2411

Merged
merged 10 commits into from
Nov 18, 2024

Conversation

pawellytaev
Copy link
Contributor

trafo3w tap at star point worked only if tap_neutral was 0. This PR fixes this issue

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.98%. Comparing base (6e8bfa2) to head (68af891).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2411   +/-   ##
========================================
  Coverage    75.98%   75.98%           
========================================
  Files          282      282           
  Lines        32962    32963    +1     
========================================
+ Hits         25047    25048    +1     
  Misses        7915     7915           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hilbrich hilbrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, the changes for the consideration of neutral step position look fine for me.

Copy link
Contributor

@gbanerjeefraunhofer gbanerjeefraunhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the changes and looks good

@pawellytaev pawellytaev merged commit 9ae66ed into e2nIEE:develop Nov 18, 2024
17 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants