Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandas deprecation fix for read_json #2125

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

vogt31337
Copy link
Contributor

Hi,

since pandas version 2.10 read_json from literal (string) is deprecated. The message is really annoying and messes up logfiles.
Therefore this patch, which will wrap a string into an StringIO object (as recommmended by the pandas people). Probably it will also be faster?

BR

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5592ba1) 78.97% compared to head (9b529f7) 78.97%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2125   +/-   ##
========================================
  Coverage    78.97%   78.97%           
========================================
  Files          214      214           
  Lines        26718    26722    +4     
========================================
+ Hits         21101    21105    +4     
  Misses        5617     5617           
Files Changed Coverage Δ
pandapower/io_utils.py 75.33% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Recommended by codacy
@rbolgaryn rbolgaryn merged commit ae6d854 into e2nIEE:develop Sep 14, 2023
19 checks passed
@rbolgaryn rbolgaryn self-assigned this Sep 14, 2023
@rbolgaryn rbolgaryn added compatibility fileIO maintenance miscellaneous tasks for housekeeping and maintenance labels Sep 14, 2023
@rbolgaryn rbolgaryn assigned vogt31337 and unassigned rbolgaryn Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility fileIO maintenance miscellaneous tasks for housekeeping and maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants