Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional patches for plotter #1998

Merged
merged 32 commits into from
Aug 8, 2023
Merged

Additional patches for plotter #1998

merged 32 commits into from
Aug 8, 2023

Conversation

hzraja
Copy link
Contributor

@hzraja hzraja commented Apr 25, 2023 •
edited
Loading

  • Added patch for the Wind turbine
  • Added patch for PV
  • static alignment for generic patches based on the different patch type at each bus (3 patches -> 120°, 4 patches -> 90°)
  • Fix visual Bugs
  • Add changes to \pandapower\CHANGELOG.rst

@hzraja hzraja closed this Apr 25, 2023
@jwiemer112 jwiemer112 reopened this Apr 25, 2023
@jwiemer112 jwiemer112 self-requested a review April 25, 2023 13:45
@codecov
Copy link

codecov bot commented Apr 25, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -1.86% ⚠️

Comparison is base (0cffae0) 78.86% compared to head (8cc38ed) 77.01%.

❗ Current head 8cc38ed differs from pull request most recent head 555ebf1. Consider uploading reports for the commit 555ebf1 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1998      +/-   ##
===========================================
- Coverage    78.86%   77.01%   -1.86%     
===========================================
  Files          213      213              
  Lines        26539    26511      -28     
===========================================
- Hits         20931    20417     -514     
- Misses        5608     6094     +486

see 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hzraja
Copy link
Contributor Author

hzraja commented Jul 4, 2023

New_patches

jwiemer112
jwiemer112 reviewed Aug 1, 2023
View reviewed changes
Copy link
Contributor

@jwiemer112 jwiemer112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finnish bugs fixing

jwiemer112
jwiemer112 requested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@jwiemer112 jwiemer112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finnish bugs fixing

@hzraja
Copy link
Contributor Author

hzraja commented Aug 7, 2023

finnish bugs fixing

@hzraja hzraja closed this Aug 7, 2023
@hzraja hzraja reopened this Aug 7, 2023
@jwiemer112 jwiemer112 merged commit bb687d7 into e2nIEE:develop Aug 8, 2023
12 of 17 checks passed
@hzraja hzraja deleted the personal_develop branch August 8, 2023 12:20
@jkisse
Copy link
Contributor

jkisse commented Aug 9, 2023

This PR causes inconsistencies with pandapipes, i.e. the test are failing. Could you please repair that?

jwiemer112 added a commit that referenced this pull request Aug 9, 2023
@jwiemer112
Revert "Additional patches for plotter (#1998)"
284d983 
This reverts commit bb687d7.
jwiemer112 added a commit that referenced this pull request Aug 9, 2023
@jwiemer112
Revert "Additional patches for plotter (#1998)" (#2107)
e1cb1d2 
This reverts commit bb687d7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwiemer112 jwiemer112 jwiemer112 approved these changes

Assignees

@jwiemer112 jwiemer112

@hzraja hzraja

Labels
plotting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hzraja @jkisse @jwiemer112