Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contingency #1837

Merged
merged 59 commits into from
Oct 5, 2023
Merged

Contingency #1837

merged 59 commits into from
Oct 5, 2023

Conversation

rbolgaryn
Copy link
Member

implements contingency evaluation functions (N-1 analysis)

@rbolgaryn
Copy link
Member Author

seems that you are still working on the tutorial, so:

* fix the ending of the 1st sentence in the last section

Three questions, which I guess are considered, but just to be sure:

1. With `res = pp.contingency.run_contingency(net, nminus1_cases)`, `res["line"]["loading_percent"]` represents the n-0 results (similar for bus results). Is it somewhere documented? (I didn't find it in the docstring.)

2. It should be mentioned what kind of results come within the `res_` tables after contingency analysis with `write_to_net is True`. Are these the n-0 results?

3. Is `net.line.max_loading_percent` considered when evaluating `res["line"]["cause_overloadings"]`? I guess yes but wanted to ask for sure...

Hi Steffen, here the answers:

  • tutorial is updated
  • the "loading_percent" variable in the results is for N-0 case (updated docstrings)
  • added more information in the docstrings about what results are returned after contingency calculation
  • net.line.max_loading_percent is considered. If provided, net.max_loading_percent_nminus1 is considered for N-1 (added in docstrings)

@SteffenMeinecke
Copy link
Member

Hi Steffen, here the answers:

Perfect, then please merge.

SteffenMeinecke
SteffenMeinecke previously approved these changes Oct 5, 2023
pandapower/test/contingency/test_contingency.py Outdated Show resolved Hide resolved
pandapower/test/contingency/test_contingency.py Outdated Show resolved Hide resolved
@rbolgaryn rbolgaryn merged commit fe6d9c1 into e2nIEE:develop Oct 5, 2023
16 of 19 checks passed
@rbolgaryn rbolgaryn deleted the contingency branch October 5, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants