Add ability to select items via config #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename items to size (which is used internally) use items as option to select nodes (useful if items are not direct descendants) this change makes it possible to use magic-grid with custom elements (web components)
|
Seems interesting but I don't understand the use case. Currently the library allows you to specify a container so that you don't have to specify the children. This PR would be allowing users to specify the children so they don't have to specify the container? What does this achieve? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename
itemstosize(which is used internally)use
itemsas option to select nodes (useful if items are not direct descendants)this change makes it possible to use magic-grid with custom elements (web components)