Mods to the constraint class #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t__ to prevent norm_calc_final error
…otebook whivh reflects those changes
…aint on data) for all shape classes into BaseConstraint
… notebook with the same
…s in BaseConstraint. Changed constraints to get_constraint_indices. Notebook reflects the chnages
…testing functions on dataframe (OPTITWIST jupyter notebook)
…ons in _constraints based on discussions with Josh and Mohammad
…ser defined constraints and examples on how to implement it
…on to be greater than the optimal number suggested by plain QR and example notebook reflecting the same
…w changes for the constraints class), addressing Josh's comments on this class and notebooks reflecting all of the functionalities of this class
… way user defined constraints are plotted for various string,equation implementations
…l as being able to plot on multiple axes for plot_constraints_on_data and subsequent plotting functions. Adding different colours to annotate_sensors and plotting_selected_sensors to reflect effect of constraints on sensors selected. Jupyter notebooks updated to reflect these changes
…tion as the matplotlib ellipse function requires the diameter or the vertical and horizontal axis and we were giving it half_major_axis and half_minor_axis)
…ction() of class Ellipse(), the functional_constraints_class notebook reflects these chnages
…' into Jimmy-handling-functional-Constraints
…aints [WIP] adding more unit tests for _constraint.py
…traints_class Ni converting functional constraints class
… better handling of wrong inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't push to your branch so I generated another PR to your PR. I will keep pushing to it and let you know when you can revise and merge