Add support for formatted test #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very much appreciated! However, I got a crash when I used this and tried to send a message. I used an It looks like it's in a different section, so probably the memory error has already happened sometime earlier. |
|
Yeah, since posting the PR, I've been seeing approx 5% of sent messages having some kind of memory error - either an outright crash, or the message body gets replaced with the channel ID - but when I step through with gdb everything looks ok (stupid heisenbugs!) I don't have access to valgrind (since I'm on Windows) but do you think you could run Pidgin through valgrind @kacf to see if it reveals where the corruption is happening? The other bug I'm seeing after this PR is that incoming smileys which have underscores in them, eg |
|
In a very cursory try I'm getting: Which looks like escaped is getting freed twice. Probably |
|
Thanks for the help @dylex and @kacf :) I should have paid more attention to the function that does in-place modification, so added some safety to it (should upstream for the discord prpl too) |
|
Great! I will retry! (sorry, I was planning to do the Valgrind thing, but time flies and dylex beat me to it!) |
`markdown_html_to_markdown()` returns a malloc'ed variable and frees the input variable. Therefore it is `marked` we need to free, not `escaped`. Signed-off-by: Kristian Amlie <[email protected]>
|
It's still not quite right. The On a side note, I could not get code blocks to render any differently than normal text, but I can see from the log that the correct HTML is indeed there, so this may be a Pidgin issue, and not a Slack plugin issue. |
Fix incorrect free()'ing of markdown variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Got a little annoyed at copy-pasting tags into messages and then getting stuck, but then took it a whole bunch further...)
This PR uses the markdown conversion code from purple-discord, tweaked for Slack's flavour of markdown, and uses it to convert to/from HTML (or specifically, Pidgin's HTML)
Would be good to get some tests/feedback on it :)