Merge pull request #135 from dxw/allow-specifying-secrets-in-app-cont…

…ainer-definition Allow specifying secrets in app container definition
dxw · Jul 24, 2024 · 82977fa · 82977fa
2 parents 5592864 + d7dff41
commit 82977fa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/container-definitions/app.json.tpl b/container-definitions/app.json.tpl
@@ -32,6 +32,9 @@
     %{ if environment != "[]" }
     "environment": "${environment},
     %{ endif }
+    %{ if secrets != "[]" }
+    "secrets": "${secrets},
+    %{ endif }
     %{ if environment_file_s3 != "" }
     "environmentFiles": [
       {

diff --git a/ecs-cluster-infrastructure-service-scheduled-task.tf b/ecs-cluster-infrastructure-service-scheduled-task.tf
@@ -22,6 +22,7 @@ resource "aws_ecs_task_definition" "infrastructure_ecs_cluster_service_scheduled
       entrypoint          = each.value["entrypoint"] != null ? jsonencode(each.value["entrypoint"]) : "[]"
       environment_file_s3 = "${aws_s3_bucket.infrastructure_ecs_cluster_service_environment_files[0].arn}/${each.value["container_name"]}.env"
       environment         = jsonencode([])
+      secrets             = jsonencode([])
       container_port      = 0
       extra_hosts = each.value["extra_hosts"] != null ? jsonencode([
         for extra_host in each.value["extra_hosts"] : {

diff --git a/ecs-cluster-infrastructure-service.tf b/ecs-cluster-infrastructure-service.tf
@@ -224,6 +224,7 @@ resource "aws_ecs_task_definition" "infrastructure_ecs_cluster_service" {
       entrypoint          = each.value["container_entrypoint"] != null ? jsonencode(each.value["container_entrypoint"]) : "[]"
       environment_file_s3 = "${aws_s3_bucket.infrastructure_ecs_cluster_service_environment_files[0].arn}/${each.key}.env"
       environment         = jsonencode([])
+      secrets             = jsonencode([])
       container_port      = each.value["container_port"] != null ? each.value["container_port"] : 0
       extra_hosts = each.value["container_extra_hosts"] != null ? jsonencode([
         for extra_host in each.value["container_extra_hosts"] : {