Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CloudWatch Slack Alerts Lambda message format #78

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fix CloudWatch Slack Alerts Lambda message format #78

merged 1 commit into from
Jan 23, 2024

Conversation

Stretch96
Copy link
Member

@Stretch96 Stretch96 commented Jan 16, 2024 •
edited
Loading

  • Creates a dict rather than creating a JSON string and loading it
  • Checks if the message result is a string, and creates a dict if it is
  • Removes the 'return True', which is causing the function to exit early

@Stretch96 Stretch96 force-pushed the fix-cloudwatch-slack-alerts-lambda-message-format branch from 92d509d to 678cfdc Compare January 16, 2024 19:12
@Stretch96
Fix CloudWatch Slack Alerts Lambda message format
f4397e4 
* Creates a dict rather than creating a JSON string and loading it
* Checks if the message result is a string, and creates a dict if it is
* Removes the 'return True', which is causing the function to exit early
@Stretch96 Stretch96 force-pushed the fix-cloudwatch-slack-alerts-lambda-message-format branch from 678cfdc to f4397e4 Compare January 16, 2024 19:24
@Stretch96 Stretch96 merged commit be62807 into main Jan 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjw1 rjw1 rjw1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stretch96 @rjw1