Fix KMS and S3 policies #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stretch96
force-pushed
the
fix-kms-and-s3-policies
branch
5 times, most recently
from
7827d1b to
0560389
Compare
* `jsonencode`s the s3 log bucket source arns * Correctly formats `service-allow-decrypt.json.tpl` * Uses the key arn rather than alias for cloudtrail * Replaces the key arn with a wildcard, as ARNs can't contain wildcards * Corrects the logs service name * Adds the aws account ID to the logs bucket, so that it is globally unique
Stretch96
force-pushed
the
fix-kms-and-s3-policies
branch
from
0560389 to
3d8125a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsonencodes the s3 log bucket source arnsservice-allow-decrypt.json.tpl