New layout #1204
Merged
New layout #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for laughing-payne-b9fbd2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yndajas
force-pushed
the
new-layout
branch
2 times, most recently
from
694022a to
a6c6b50
Compare
yndajas
force-pushed
the
new-layout
branch
3 times, most recently
from
18b9e57 to
8d7dd8a
Compare
jdudley1123
approved these changes
Oct 17, 2023
| @@ -13,9 +13,9 @@ | |||
| {% endif %} | |||
| {% endif %} | |||
|
|
|||
| <footer class="contribute" data-proofer-ignore> | |||
| <a href="/admin/#/collections/{{ collection_name }}/entries/{{ entry_name }}">Edit this page</a> | |||
| <div class="contribute" data-proofer-ignore> | |||
There was a problem hiding this comment.
Is the change from <footer> to <div> a semantic change or just a styling one?
There was a problem hiding this comment.
Semantic - the large screen layout is now horizontal, so I'm considering the left side the header and right main. On small screens the contribute section isn't shown. Not sure whether this is good practice though?
There was a problem hiding this comment.
On a stylistic note, it would actually work fine if it was still a footer given the fixed positioning. I'm going back and forth on whether it should live in the header, main, or footer semantically 🤔
Constrain the nav and contribute element to the same width as the related content menu, allowing the main article to stretch the full height of the viewport
- Reduce the font weight - Add the dxw 'D' as a list item indicator (excluding the back link), which is a style adopted from our main site's [impact report][1] - Remove the second line indent [1]: https://www.dxw.com/dxw-impact
Index pages (i.e. pages which have children but not their own content) include the same partial as the nav menu. This menu includes a 'Contact dxw' link, which looks a little out of place in the body of the index page. This makes it so that the 'Contact dxw' link will only appear in the nav, not the list of child pages on index pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1199
Closes #1142
See those issues for more context
Summary of changes
On large screens:
On all screen sizes:
Previews
Interactive
Available at https://deploy-preview-1204--laughing-payne-b9fbd2.netlify.app
Video
Screen.Recording.2023-10-16.at.21.08.30.mov