Optimise search excerpt to highlight more relevant results #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for laughing-payne-b9fbd2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lookupdaily
changed the title
yndajas
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Nice! This seems to be doing the job - tested with the "flexible working example", comparing the excerpt in the sixth result with that on the live version of the playbook
I've included a suggestion for DRYing this up, but I think it's good to merge in principle
Before
After
yndajas
approved these changes
Feb 8, 2023
lookupdaily
force-pushed
the
issue/1074-optimize-search-excerpt
branch
from
e148669 to
a55d57b
Compare
Currently a search excerpt is generated by searching for the index of each separate term and selecting the first match for the first word (or the first match for the second if it is not found). Here have added a search for the full term, so that an excerpt containing a full match will be prioritized over one containing just one word. The function uses two variables: information for the first (if any) full match, and a list of information on the first match for each word in the search query. Even if a full match is found, the list of individual term matchers is used for highlighting terms in the excerpt display.
lookupdaily
force-pushed
the
issue/1074-optimize-search-excerpt
branch
from
a55d57b to
fdac5dc
Compare
For consistency with the rest of file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a search result excerpt is generated by searching for the index of each separate term and selecting the first match for the first word (or the first match for the second if it is not found). This means that when selecting the first excerpt from the page it may not be the most relevant to the user as it may contain the first term only when there is a result lower down the page which contains the full term. (Issue #1074 )
This change looks for an excerpt containing the full search term first, so a full match will be prioritised over one containing just one word.
A few considerations:
Resolves issue #1074