Update integration GitHub Action #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8572097387Details
💛 - Coveralls |
mec
force-pushed
the
chore/break-up-workflow-and-run-sending-tests
branch
8 times, most recently
from
112c9e8 to
f46977f
Compare
We added the new sending integration tests so we want to runs those. Because we know the previewing and the sending are the two main features, we want them to show up in GitHub separately so we break the build and test jobs up passing the built image between via uploading as an artifact. There is nothing secret in the built image as we only have on secret and that is passed into the running container not the image. Until v2 is released, we expect the preview tests to FAIL but the sending should work as this reflects the current state of the gem.
mec
force-pushed
the
chore/break-up-workflow-and-run-sending-tests
branch
from
f46977f to
a4a1ebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added the new sending integration tests so we want to runs those.
Because we know the previewing and the sending are the two main
features, we want them to show up in GitHub separately so we break the
build and test jobs up passing the built image between via uploading as
an artifact.
There is nothing secret in the built image as we only have on secret and
that is passed into the running container not the image.
Until v2 is released, we expect the preview tests to FAIL but the
sending should work as this reflects the current state of the gem.