Skip to content

Commit

Permalink
Merge pull request #90 from dxw/chore/update-rails-mocks
Browse files Browse the repository at this point in the history
Unpin rspec mocks
  • Loading branch information
mec authored Apr 28, 2023
2 parents 2ecfd99 + 810be80 commit 1e8f5e1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
5 changes: 1 addition & 4 deletions mail-notify.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "standard", "~> 1"
spec.add_development_dependency "sqlite3", "~> 1.6.2"
spec.add_development_dependency "webmock", "~> 3.16.0"
# Note: we pin rspec-mocks only because 3.10.3 is broken; see
# https://github.com/rspec/rspec-mocks/issues/1460
# and the commit message for this commit
spec.add_development_dependency "rspec-mocks", "3.10.2"
spec.add_development_dependency "rspec-mocks", "~> 3.11.0"

spec.add_dependency "actionmailer", ">= 5.2.4.6"
spec.add_dependency "activesupport", ">= 5.2.4.6"
Expand Down
6 changes: 3 additions & 3 deletions spec/mail/notify/mailer_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

context "with a view" do
it "sends the template" do
expect(mailer).to receive(:mail).with(template_id: "foo", bar: "baz")
expect(mailer).to receive(:mail).with({template_id: "foo", bar: "baz"})
mailer.view_mail("foo", bar: "baz")
end

Expand All @@ -21,12 +21,12 @@

context "with a template" do
it "sends a blank body and subject" do
expect(mailer).to receive(:mail).with(
expect(mailer).to receive(:mail).with({
template_id: "foo",
bar: "baz",
body: "",
subject: ""
)
})
mailer.template_mail("foo", bar: "baz")
end

Expand Down

0 comments on commit 1e8f5e1

Please sign in to comment.