Improve Styling #227
Open
Improve Styling #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should hide the "Reset round" button until you enter the Konami code Edit: done in #228 |
richpjames
force-pushed
the
styling
branch
10 times, most recently
from
f6627d2 to
6aff9b5
Compare
added 12 commits
September 17, 2024 10:35
We can use these as a rudimentary design system to ensure our styling stays consistent and DRY
We've added the vars, lets use them.
This ensures that main fills the full visible viewport
This adds a simple column layout with the gameplay area (2/3rds of viewport) to the left and a column displaying meta information to the right (1/3 of viewport).
I think this is a little clearer
We also re-add the list styling as I think the bullet points add clarity
This ensures it displays in the correct place
Making sure it displays in the correct place
This makes it a bit clearer these are labels and not just words
This may make more sense in the colour-card.css file but as it was styling the top level component I put it in the general css file. I think it's fine that the colour-cards file doesn't use the CSS vars as it's a seperate component, but it makes sense for all the components in this file to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves things a bit, still lots of room for improvement.
I've introduced a basic column layout and lots of CSS variables for us to use.
This needs to go in after #210