If the post_author is a deleted user, change it to a specified user #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Posts having post_author ids that refer to deleted users cause problems - even if co-authors is populated. In the short term, don't attempt to resolve the author, and independently find posts with a) deleted authors b) populated co-authors and switch them to be user 0
|
@leedxw Is there a known way to recreate the issue this fixes? Without this fix, I've tried authoring a post, and then removing the post author from the database entirely, but the page still renders just with an empty author. I do see a PHP warning in the logs: Is the intention of this fix to address that warning? |
|
It addresses this warning, but you'll also see a perpetual spinner under "Authors" if you edit the page. |
|
(I suspect there are other issues related to posts that have owners for which lookups fail.) |
|
Note that we shouldn't apply this to production until we have reassigned the existing deleted-author posts to an existing author. This output is intended to explain future issues from deleted users. |
leedxw
force-pushed
the
chore/no-coauthors-on-page
branch
3 times, most recently
from
3c64b91 to
10ca0ea
Compare
Sets the post_author to 2 if the actual post_author is not found
leedxw
force-pushed
the
chore/no-coauthors-on-page
branch
from
10ca0ea to
d5733b4
Compare
RobjS
reviewed
Dec 13, 2024
leedxw
changed the title
leedxw
force-pushed
the
chore/no-coauthors-on-page
branch
from
1d79929 to
788cabd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Posts having post_author ids that refer to deleted users cause problems - even if co-authors is populated.
In the short term, don't attempt to resolve the author, and independently find posts with
a) deleted authors
b) populated co-authors
and switch them to be an archive user