Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add barebones start page #19

Merged
merged 4 commits into from
Jul 12, 2024
Merged

Add barebones start page #19

merged 4 commits into from
Jul 12, 2024

Conversation

dynamictulip
Copy link
Member

@dynamictulip dynamictulip commented Jul 12, 2024 •
edited by lookupdaily
Loading

Changes in this PR

This sets up a basic page model for views, and adds the landing page for the application:

  • Remove redundant code from ASP.NET Razor Pages template
  • Add BasePageModel for managing common properties such as headings - this tells the developer what properties are required on pages rather than relying on them to set up ViewData in the razor template.
  • Add html for Apply For Landing home page - note that no styles are currently installed, so while the html includes GOV.UK Design System classes, these will not yet apply styles in the application.

Screenshots of UI changes

screenshot of Apply For Landing homepage

Next steps

@dynamictulip dynamictulip requested a review from lookupdaily July 12, 2024 14:04
@dynamictulip
Add a base page model
57912d7 
This will enable us to enforce setting of properties on each page - such as a page heading , for use in the layout.
@dynamictulip
Add dynamic list of landable bodies
d7afac0
@dynamictulip dynamictulip force-pushed the afl-40-add-barebones-start-page branch from a86f88b to d7afac0 Compare July 12, 2024 14:09
lookupdaily
lookupdaily approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@lookupdaily lookupdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot

@dynamictulip dynamictulip changed the title WIP - Afl 40 add barebones start page Afl 40 add barebones start page Jul 12, 2024
@dynamictulip dynamictulip changed the title Afl 40 add barebones start page AFL 40: Add barebones start page Jul 12, 2024
@dynamictulip dynamictulip changed the title AFL 40: Add barebones start page Add barebones start page Jul 12, 2024
@dynamictulip dynamictulip added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit 2a785a3 Jul 12, 2024
2 checks passed
@dynamictulip dynamictulip deleted the afl-40-add-barebones-start-page branch July 12, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lookupdaily lookupdaily lookupdaily approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dynamictulip @lookupdaily