Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fatal error on Options page #647

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Fix fatal error on Options page #647

merged 1 commit into from
Nov 15, 2024
+96 −88

Conversation

serena-piccioni
Copy link
Contributor

Description

This PR fixes a PHP fatal error on the Options page when calling acf_add_options_sub_page without checking if the function exists:

PHP Fatal error:  Uncaught Error: Call to undefined function Dxw\DxwSecurity2017\Theme\acf_add_options_sub_page() in /var/www/html/wp-content/themes/dxw-security-2017/app/Theme/OptionsPage.php:9

It also adds the check for the Custom fields.

jkeasley
jkeasley approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@jkeasley jkeasley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serena-piccioni serena-piccioni merged commit 50bd625 into develop Nov 15, 2024
9 checks passed
@serena-piccioni serena-piccioni deleted the fix/fatal-error-on-options-page branch November 15, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkeasley jkeasley jkeasley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serena-piccioni @jkeasley