Fix deprecation warnings

[patdel0]

This is to fix the deprecation warnings:

[DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest
version 2, schema 1 support is disabled by def

and

How to Test

2. Perform a search on the site
3. Confirm you are seeing the deprecation errors
4. Checkout this branch
5. Run:

cd wp-content/themes/dxw-security-2017; composer update -W

6. Refresh the page and confirm the errors are no longer present

[snim2]

@patdel0 two quick questions, how are you seeing those PHP errors and why do we need to run composer?

[patdel0]

@snim2 Thanks for having a look at this one.

• I am seeing them locally through query monitor. You can also see them on staging. This is happening whenever you search for a term on the site.

• You might want to run composer to install the latest version of dxw/pagination.
  Although the composer files were updated,vendor/ is ignored in the repo. I reckon that when you switch to this branch, you'll find it's still running with v1.0 because of that.
  An alternative is to run ./script/setup again, but a composer run seems to be the faster option.

[snim2]

@snim2 Thanks for having a look at this one.

• I am seeing them locally through query monitor. You can also see them on staging. This is happening whenever you search for a term on the site.

OK, I'll check that tomorrow

• You might want to run composer to install the latest version of dxw/pagination.
  Although the composer files were updated,vendor/ is ignored in the repo. I reckon that when you switch to this branch, you'll find it's still running with v1.0 because of that.
  An alternative is to run ./script/setup again, but a composer run seems to be the faster option.

The new version of the dependency should be packaged in the vendor.phar file, so that when the code is deployed it deploys with exactly the dependencies that the developer intended. composer install is usually for local development, where we have some special reason for needing the vendor/ directory (for example, because it might be easier to run a particular binary from the command line).

[snim2]

This is what I see in Query Monitor btw

[patdel0]

When searching for "private" does it have sufficient results to require pagination?

[snim2]

When searching for "private" does it have sufficient results to require pagination?

Well, that was exciting. private only had 3 responses for me, but vuln had 3 pages.