adds render_fields function to generate form from schema #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Danwhy please assign for review if you feel it's mergeable. thanks! |
|
@nelsonic As this is mostly just the same code that's now in https://github.com/dwyl/autoform, I thought it would probably be best to just close this PR and include it as a hex package once it's ready if we need it |
|
@Danwhy thanks for update. agreed. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
render_fields/4function, which can be called from a Phoenix Controller, and will generate a form for either an:updateor:create('edit' or 'new') action, based on a given schema.ref #6, dwyl/adoro#108
I'm going to add some more tests before it's ready for merge, plus I've temporarily removed the code that was used to incrementally update the data, as it was causing issues with updates being submitted too many times.