Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/logos #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/logos #24

wants to merge 2 commits into from

Conversation

d-rk
Copy link
Contributor

@d-rk d-rk commented Feb 4, 2022

Hey,

this is the final thing I modified and wanted to contribute back.
I added logos for all the engines:
Screenshot from 2022-02-04 09-57-32
Screenshot from 2022-02-04 09-57-49

@jwpjrdev
Copy link

jwpjrdev commented Feb 4, 2022

Lingo is https://lingoapp.com, not Duolingo

@d-rk
Copy link
Contributor Author

d-rk commented Feb 4, 2022

@jwpjrdev thank you for the hint. I updated the logo

@artnc
Copy link
Member

artnc commented Feb 7, 2022

Wow! I'm curious, where did you get the images from? One reason why I hadn't done this being that I was never sure about committing to also providing images for all new engines going forward

@d-rk
Copy link
Contributor Author

d-rk commented Feb 11, 2022

@artnc actually that was quite cumbersome 🙈 I first just added it for the services we are using internally. But for this PR I had to find all logos, which took some time. I mainly checked the brand/marketing pages of the companies for the logos. But for some of them I had to grab them elsewhere.

I think going forward this shouldn't be a problem, because for a new engine that needs to be added only a single logo has to be found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants