feat: print message when docker-entrypoint finishes #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
requested changes
Nov 26, 2024
Works for me ;) Co-authored-by: Kévin Dunglas <[email protected]>
maxhelias
approved these changes
Nov 27, 2024
dunglas
approved these changes
Nov 27, 2024
dunglas
changed the title
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement :
When running docker compose, for a few seconds / minutes, the container is running according to Docker, but in fact
docker-entrypoint.shis still downloading composer requirements and handling migrations. During this time, the app is not available. This means functionnal tests will fail if launched too early.Solution proposed :
This pull requests aims to simply add a logging line at the end of
docker-enntrypoint.sh, to provide a standard log that can be watched by dev / devops teams. Agrepon docker logs will make people aware that : "ok, dependencies should be installed by now, so my app should be working".