Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENSE #686

Closed
wants to merge 1 commit into from
Closed

Conversation

anzweidrej
Copy link

No description provided.

@dunglas
Copy link
Owner

dunglas commented Nov 10, 2024

I don't think we should merge this because the repository is a template, and the file will be included in rejects created from this template, which are likely not MIT-licensed.

@anzweidrej
Copy link
Author

Hi Kévin,

Thanks for the reply. I am in no way a lawyer, but as far as I am informed, the problem with repositories that don't make licenses explicitly available, including only a partial mention in the README file, without actual permission-notice, as in the current case, means that any user who gets the code is effectively violating the terms.

"You're under no obligation to choose a license. However, without a license, the default copyright laws apply, meaning that you retain all rights to your source code and no one may reproduce, distribute, or create derivative works from your work."

Link

Another potential issue, which I just noticed now, is that Symfony creates its own LICENSE, which will overwrite this file if it's placed within root.

Br,

@dunglas
Copy link
Owner

dunglas commented Nov 10, 2024

According to https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository#determining-the-location-of-your-license, a mention in the README is good enough, even if having a LICENSE file is a best practice.

@maxhelias
Copy link
Collaborator

maxhelias commented Nov 12, 2024

We have this mention here : https://github.com/dunglas/symfony-docker#license
Thanks

@maxhelias maxhelias closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants