Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delete table endpoint to sdk #119

Merged
merged 6 commits into from
Apr 2, 2024
Merged

Add delete table endpoint to sdk #119

merged 6 commits into from
Apr 2, 2024

Conversation

waddahAldrobi
Copy link
Contributor

In this PR, we add support for the new table endpoints in the SDK:

We also add a _delete function to the BaseDuneClient

@waddahAldrobi waddahAldrobi requested review from bh2smith and a team April 2, 2024 11:11
helanto
helanto reviewed Apr 2, 2024
View reviewed changes
Copy link

@helanto helanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

dune_client/api/table.py Outdated Show resolved Hide resolved
tests/e2e/test_client.py Outdated Show resolved Hide resolved
dune_client/api/base.py Show resolved Hide resolved
helanto
helanto approved these changes Apr 2, 2024
View reviewed changes
Copy link

@helanto helanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment about .gitignore. Did you change on purpose ?

.gitignore
Comment on lines +10 to +11
build/
.DS_Store
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, those files are noise.
I'm adding them to the ignore so that no one accidentally pushes them.

Any concerns?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope! Just to make sure its not by accident

@waddahAldrobi waddahAldrobi merged commit 22a2659 into main Apr 2, 2024
3 checks passed
@waddahAldrobi
Copy link
Contributor Author

@bh2smith ugh, I forgot to squash merge again...
Isn't there a way to make that the default behaviour?

@waddahAldrobi waddahAldrobi mentioned this pull request Apr 2, 2024
Merged
@bh2smith
Copy link
Collaborator

bh2smith commented Apr 2, 2024

Isn't there a way to make that the default behaviour?

After you do it once, GitHub will use this default choice.

@waddahAldrobi
Copy link
Contributor Author

waddahAldrobi commented Apr 2, 2024 •
edited
Loading

Isn't there a way to make that the default behaviour?

After you do it once, GitHub will use this default choice.

Right, I was thinking of this though to enforce it
dotnet/runtime#260 (comment)

@bh2smith bh2smith deleted the support-delete-table-endpoint branch November 12, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helanto helanto helanto approved these changes

@bh2smith bh2smith Awaiting requested review from bh2smith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waddahAldrobi @bh2smith @helanto