Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Types on Create and Insert Table #117

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Return Types on Create and Insert Table #117

merged 5 commits into from
Mar 25, 2024

Conversation

bh2smith
Copy link
Collaborator

@bh2smith bh2smith commented Mar 25, 2024

Following up on a comment in #114. This PR introduces a cool new dataclass from dict/json parsing tool.

Note that we could also replace all the manually implemented "from_dict" methods throughout this project.

The expected way to use this dataclass_json library is as a decorator, but it fails the linter. There is an open issue in their repo related to this: lidatong/dataclasses-json#198 (comment)

Copy link
Collaborator

@RichardKeo RichardKeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests that are failing are likely unrelated to the changes introduced here; instead they are small changes we made to the backend to restore the date format to what it was before we made some other changes.

dune_client/api/table.py Outdated Show resolved Hide resolved
Copy link
Contributor

@waddahAldrobi waddahAldrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!
But just shared thoughts on consistency of data class name

dune_client/models.py Show resolved Hide resolved
Copy link
Contributor

@waddahAldrobi waddahAldrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bh2smith bh2smith merged commit 3eab3fb into main Mar 25, 2024
3 checks passed
@bh2smith bh2smith deleted the table-return-types branch March 25, 2024 14:14
Copy link
Contributor

@hawkaa hawkaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants