Merge pull request dart-backend#141 from Garthi/feature/fix_table_ind…

…ex_setting add/fix table index setting
dukefirehawk · Jul 8, 2024 · 6c71ee3 · 6c71ee3
2 parents b71f350 + 3803fd0
commit 6c71ee3
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 1 deletion.
diff --git a/packages/orm/angel_migration/lib/src/column.dart b/packages/orm/angel_migration/lib/src/column.dart
@@ -21,7 +21,7 @@ class MigrationColumn extends Column {
   MigrationColumn(ColumnType type,
       {bool isNullable = true,
       super.length,
-      IndexType indexType = IndexType.standardIndex,
+      IndexType indexType = IndexType.none,
       dynamic defaultValue})
       : super(type: type, isNullable: isNullable, defaultValue: defaultValue) {
     _nullable = isNullable;

diff --git a/packages/orm/angel_migration_runner/lib/src/mariadb/table.dart b/packages/orm/angel_migration_runner/lib/src/mariadb/table.dart
@@ -57,6 +57,14 @@ abstract class MariaDbGenerator {
     return buf.toString();
   }
 
+  static String? compileIndex(String name, MigrationColumn column) {
+    if (column.indexType == IndexType.standardIndex) {
+      return ' INDEX(`$name`)';
+    }
+
+    return null;
+  }
+
   static String compileReference(MigrationColumnReference ref) {
     var buf = StringBuffer('REFERENCES ${ref.foreignTable}(${ref.foreignKey})');
     if (ref.behavior != null) buf.write(' ${ref.behavior!}');
@@ -79,6 +87,7 @@ class MariaDbTable extends Table {
 
   void compile(StringBuffer buf, int indent) {
     var i = 0;
+    List indexBuf = [];
 
     _columns.forEach((name, column) {
       var col = MariaDbGenerator.compileColumn(column);
@@ -89,7 +98,16 @@ class MariaDbTable extends Table {
       }
 
       buf.write('$name $col');
+
+      var index = MariaDbGenerator.compileIndex(name, column);
+      if (index != null) indexBuf.add(index);
     });
+
+    if (indexBuf.isNotEmpty) {
+      for (var i = 0; i < indexBuf.length; i++) {
+        buf.write(',\n${indexBuf[$1]}');
+      }
+    }
   }
 }
 

diff --git a/packages/orm/angel_migration_runner/lib/src/mysql/table.dart b/packages/orm/angel_migration_runner/lib/src/mysql/table.dart
@@ -56,6 +56,14 @@ abstract class MySqlGenerator {
     return buf.toString();
   }
 
+  static String? compileIndex(String name, MigrationColumn column) {
+    if (column.indexType == IndexType.standardIndex) {
+      return ' INDEX(`$name`)';
+    }
+
+    return null;
+  }
+
   static String compileReference(MigrationColumnReference ref) {
     var buf = StringBuffer('REFERENCES ${ref.foreignTable}(${ref.foreignKey})');
     if (ref.behavior != null) buf.write(' ${ref.behavior!}');
@@ -78,6 +86,7 @@ class MysqlTable extends Table {
 
   void compile(StringBuffer buf, int indent) {
     var i = 0;
+    List indexBuf = [];
 
     _columns.forEach((name, column) {
       var col = MySqlGenerator.compileColumn(column);
@@ -88,7 +97,16 @@ class MysqlTable extends Table {
       }
 
       buf.write('$name $col');
+
+      var index = MySqlGenerator.compileIndex(name, column);
+      if (index != null) indexBuf.add(index);
     });
+
+    if (indexBuf.isNotEmpty) {
+      for (var i = 0; i < indexBuf.length; i++) {
+        buf.write(',\n${indexBuf[$1]}');
+      }
+    }
   }
 }