bug: Screen 에서는 FinishActivity emit 하지 않음 & FinishActivity emit 은 Vie…

…wModel 에서만 진행 (#439)
duckie-team · Apr 30, 2023 · f7e2245 · f7e2245
1 parent b2a9c5e
commit f7e2245
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/.../kotlin/team/duckie/app/android/feature/ui/create/problem/screen/ExamInformationScreen.kt b/.../kotlin/team/duckie/app/android/feature/ui/create/problem/screen/ExamInformationScreen.kt
@@ -7,6 +7,7 @@
 
 package team.duckie.app.android.feature.ui.create.problem.screen
 
+import android.app.Activity
 import androidx.activity.compose.BackHandler
 import androidx.compose.animation.AnimatedVisibility
 import androidx.compose.foundation.layout.Arrangement
@@ -32,6 +33,7 @@ import androidx.compose.ui.focus.focusRequester
 import androidx.compose.ui.focus.onFocusChanged
 import androidx.compose.ui.layout.Layout
 import androidx.compose.ui.layout.layoutId
+import androidx.compose.ui.platform.LocalContext
 import androidx.compose.ui.platform.LocalFocusManager
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.input.ImeAction
@@ -79,6 +81,7 @@ internal fun ExamInformationScreen(
     viewModel: CreateProblemViewModel = activityViewModel(),
     modifier: Modifier,
 ) {
+    val activity = LocalContext.current as Activity
     val state = viewModel.collectAsState().value.examInformation
     val coroutineScope = rememberCoroutineScope()
     val focusManager = LocalFocusManager.current
@@ -270,7 +273,7 @@ internal fun ExamInformationScreen(
         rightButtonText = stringResource(id = R.string.ok),
         rightButtonOnClick = {
             createProblemExitDialogVisible = false
-            viewModel.finishCreateProblem()
+            activity.finish()
         },
         onDismissRequest = { createProblemExitDialogVisible = false },
     )

diff --git a/...lin/team/duckie/app/android/feature/ui/create/problem/viewmodel/CreateProblemViewModel.kt b/...lin/team/duckie/app/android/feature/ui/create/problem/viewmodel/CreateProblemViewModel.kt
@@ -276,7 +276,7 @@ internal class CreateProblemViewModel @Inject constructor(
     }
 
     /** 문제 만들기 화면을 종료한다. */
-    internal fun finishCreateProblem() = intent {
+    private fun finishCreateProblem() = intent {
         postSideEffect(CreateProblemSideEffect.FinishActivity)
     }