Add Address Bar Spoofing Test Cases #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrites current document without requiring navigation first. Also uses filtered ports, see: https://app.asana.com/0/1177771139624306/1205376531515103/f
…ncoded document loads and unsupported schemes.
not-a-rootkit
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Nov 3, 2023
…gationProtectionIntegrationTests. Dependent on this PR: duckduckgo/privacy-test-pages#169
kdzwinel
reviewed
Nov 6, 2023
There was a problem hiding this comment.
Looks good! I left some comments in the code and have couple more simple asks here:
- (for findability) please add simple index.html in
/address-bar-spoofing/folder that links to all examples - (for findability) please update main index.html so that it points to
/address-bar-spoofing/ - (to keep things tidy) if https://github.com/duckduckgo/privacy-test-pages/blob/main/security/spoof-js-page-rewrite.html is no longer needed - can you please check if any of our apps/extensions mentions it and, if not, remove it?
* Add title and run buttons where missing * Update download URL from Google to something we own
kdzwinel
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
LGTM, thanks Thom! I left one comment, but feel free to merge after that. Deploy script checks every ~30min if there is anything new and auto deploys to http://privacy-test-pages.site
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Project: https://app.asana.com/0/72649045549333/1205794884403778/f
This PR adds security related test cases for address bar spoofing vulnerabilities that may arise in our browsers. The aim is to provide a more robust set of test cases to secure our browsers against address bar spoofing vulnerabilities.
Test cases covered: