Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable contextual onboarding #3667

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

SabrinaTardio
Copy link
Collaborator

@SabrinaTardio SabrinaTardio commented Dec 13, 2024

Task/Issue URL: https://app.asana.com/0/0/1208965309086157/f

Description: We want to disable the contextual onboarding while leaving the rest of the treatment variant

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:

  1. Run ./clean-app.sh debug
  2. In MainWindowController in shouldShowOnboarding leave only line 87 and 88
  3. Run the app (repeat the above steps until you get the new onboarding)
  4. go through the onboarding and at the end check that no contextual dialog is present.

<!—
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be marked with the DO NOT MERGE label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the Pending Product Review label.

If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information.
—>

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@SabrinaTardio SabrinaTardio marked this pull request as ready for review December 13, 2024 08:36
@SabrinaTardio SabrinaTardio changed the base branch from main to release/1.118.0 December 13, 2024 08:42
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please retarget to release (and you may need to update the branch so that only this change is being merged to the release branch).

@SabrinaTardio SabrinaTardio merged commit b6be200 into release/1.118.0 Dec 13, 2024
31 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/remove-contextual-onboarding branch December 13, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants