Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displaying multi-line custom background category names #3664

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Dec 12, 2024

Task/Issue URL: https://app.asana.com/0/1201621708115095/1208921971523524/f

Description:
This change fixes layout of BackgroundCategoryView to correctly align multi-line title labels with other grid items.

Steps to test this PR:

  1. Set app language to Italian
  2. Run the app from Xcode
  3. Open Customize panel in NTP
  4. Verify that background categories grid is aligned correctly.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Member

@federicocappelli federicocappelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayoy ayoy merged commit f17094d into main Dec 12, 2024
23 checks passed
@ayoy ayoy deleted the dominik/fix-customizer branch December 12, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants