VPN: Replace available interfaces in VPN metadata #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
diegoreymendez
changed the title
diegoreymendez
changed the title
diegoreymendez
removed
the
bot: not in app board
samsymons
approved these changes
Apr 16, 2024
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Apr 16, 2024
Task/Issue URL: https://app.asana.com/0/0/1207087903608440/f iOS PR: duckduckgo/iOS#2750 macOS PR: duckduckgo/macos-browser#2634 What kind of version bump will this require?: Major/Minor/Patch ## Description Replace available interfaces in VPN metadata
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Apr 16, 2024
Task/Issue URL: https://app.asana.com/0/0/1207087903608440/f macOS PR: duckduckgo/macos-browser#2634 BSK PR: duckduckgo/BrowserServicesKit#782 ## Description Removes `availableInterfaces` from VPN metadata and instead replaces it with the type of the first available interface, a count of tunnels and DNS interfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1207087903608440/f
iOS PR: duckduckgo/iOS#2750
BSK PR: duckduckgo/BrowserServicesKit#782
Description
Removes
availableInterfacesfrom VPN metadata and instead replaces it with the type of the first available interface, a count of tunnels and DNS interfaces.Testing
pothe description.Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation