-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add required information to DBP NA<->FE API for removal timeline supp…
…ort (#3268) Task/Issue URL: https://app.asana.com/0/1203581873609357/1208164179397484/f Tech Design URL: Initial API additions: https://app.asana.com/0/481882893211075/1208203761791777/f Parent - child api info and matching logic: https://app.asana.com/0/72649045549333/1208303545057273/f Where to put the matching logic: https://app.asana.com/0/481882893211075/1208325118544624/f CC: **Description**: - Adds four new fields as per the first tech design. Also moves some of the construction of these objects to constructors. - Also removes an old date field that isn't officially in the api, and apparently varied what it was used for. It seemed unused on the native side, and the FE side doesn't know it exist. - It then also adds "parent child" matching logic so we can identify orphaned child records that will never be removed. **Steps to test this PR**: 1. In DataBrokerProtectionWebUIURLSettings, change the production URL to "https://use-devtesting27.duckduckgo.com/dbp", Alex made an FE build we can use to test 2. In the DBP UI, click on individual records, this will show you things like the opt out submitted date 3. Make sure these values make sense, e.g. we don't ever show 1970, the timeline follows linear time, nothing violates causality etc. <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
- Loading branch information
1 parent
d26425d
commit f8a3914
Showing
10 changed files
with
616 additions
and
57 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.