Skip to content

Commit

Permalink
Re-enable csv import integration tests (#3329)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/1203822806345703/1207759292115039/f

**Description**:

**Steps to test this PR**:
1. Just make sure CI is green

**Definition of Done**:

* [ ] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?

---
###### Internal references:
[Pull Request Review
Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f)
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
[Pull Request
Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
  • Loading branch information
graeme authored Sep 24, 2024
1 parent 423f347 commit 21d2f6c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
1 change: 0 additions & 1 deletion DuckDuckGo/Localizable.xcstrings
Original file line number Diff line number Diff line change
Expand Up @@ -47609,7 +47609,6 @@
},
"pm.save-credentials.security.info" : {
"comment" : "Info message for the save credentials dialog\n Info message for the save credentials dialog when the autolock feature is off",
"extractionState" : "extracted_with_value",
"localizations" : {
"de" : {
"stringUnit" : {
Expand Down
14 changes: 7 additions & 7 deletions IntegrationTests/DataImport/CSVImporterIntegrationTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ import BrowserServicesKit

final class CSVImporterIntegrationTests: XCTestCase {

override func setUpWithError() throws {
override func setUp() {
super.setUp()
try clearDB()
try? clearDB()
executionTimeAllowance = 10
}

override func tearDownWithError() throws {
try clearDB()
override func tearDown() {
try? clearDB()
super.tearDown()
}

Expand All @@ -45,7 +45,7 @@ final class CSVImporterIntegrationTests: XCTestCase {
}
}

func _testImportPasswordsPerformance() async throws {
func testImportPasswordsPerformance() async throws {
let csvURL = Bundle(for: Self.self).url(forResource: "mock_login_data_large", withExtension: "csv")!
let csvImporter = CSVImporter(
fileURL: csvURL,
Expand All @@ -54,7 +54,7 @@ final class CSVImporterIntegrationTests: XCTestCase {
)
let importTask = csvImporter.importData(types: [.passwords])

// No baseline set, but should be no more than 0.3 seconds on an M1 Max with 32GB memory
// No baseline set, but should be no more than 0.5 seconds on an M1 Max with 32GB memory
measureMetrics([.wallClockTime], automaticallyStartMeasuring: false) {
let expectation = expectation(description: "Measure finished")
Task {
Expand All @@ -69,7 +69,7 @@ final class CSVImporterIntegrationTests: XCTestCase {
}

// Deduplication rules: https://app.asana.com/0/0/1207598052765977/f
func _testImportingPasswords_deduplicatesAccordingToDefinedRules() async throws {
func testImportingPasswords_deduplicatesAccordingToDefinedRules() async throws {
let startingDataURL = Bundle(for: Self.self).url(forResource: "login_deduplication_starting_data", withExtension: "csv")!
let startingDataImporter = CSVImporter(
fileURL: startingDataURL,
Expand Down

0 comments on commit 21d2f6c

Please sign in to comment.