Implement tab bar remote message #14708
Annotations
10 errors, 12 warnings, and 7 notices
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x16960d710> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000070280b0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x408d55a70> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000702dad0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40599a070> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007029b80> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40be879e0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007050370> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x169634320> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007058210> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x408cefd70> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000307ecb0> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L142
testWhenLastTabClosed_windowIsDeallocated, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12ec4fc60> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007045600> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x405f043d0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000731af70> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1641771b0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600003357390> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x1777a10e0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007070210> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x177780d10> should deallocate", "<DuckDuckGo_WebView: 0x12d7418e0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x172dcf450> should deallocate", "<DuckDuckGo_WebView: 0x172dcf7d0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12e9cb830> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000307c840> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x402765af0> should deallocate", "<DuckDuckGo_WebView: 0x408c57970> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40af29560> should deallocate", "<DuckDuckGo_WebView: 0x40af29fd0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x12ebf34f0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007334160> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x12e8359b0> should deallocate", "<DuckDuckGo_WebView: 0x408c55c40> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40af39110> should deallocate", "<DuckDuckGo_WebView: 0x40af397c0> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x4027895b0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007052100> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x405920b90> should deallocate", "<DuckDuckGo_WebView: 0x10d63bdc0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x4059e5630> should deallocate", "<DuckDuckGo_WebView: 0x408c99c80> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x172dd1650> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x600007040dc0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x405f952b0> should deallocate", "<DuckDuckGo_WebView: 0x40af87c80> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40afdb7d0> should deallocate", "<DuckDuckGo_WebView: 0x40afdbfa0> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x408dab720> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000070463c0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40d40a2c0> should deallocate", "<DuckDuckGo_WebView: 0x172d0a480> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x174b999a0> should deallocate", "<DuckDuckGo_WebView: 0x174b9a040> should deallocate".
|
Run integration tests:
IntegrationTests/App/DeallocationTests.swift#L99
testWindowsDeallocation, Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x40bee0380> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000738e260> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40bede770> should deallocate", "<DuckDuckGo_WebView: 0x40bedec10> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40d4661a0> should deallocate", "<DuckDuckGo_WebView: 0x40d469110> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x172d3d930> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x6000073c2260> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40afe6060> should deallocate", "<DuckDuckGo_WebView: 0x40afc4120> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x408c80000> should deallocate", "<DuckDuckGo_WebView: 0x408c90490> should deallocate", "<DuckDuckGo_Privacy_Browser.TabBarViewController: 0x16963ee40> should deallocate", "<DuckDuckGo_Privacy_Browser.TabCollectionViewModel: 0x60000702a5d0> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40d4557a0> should deallocate", "<DuckDuckGo_WebView: 0x40d455d60> should deallocate", "<DuckDuckGo_Privacy_Browser.Tab: 0x40d46e9f0> should deallocate", "<DuckDuckGo_WebView: 0x40d46f190> should deallocate".
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L495
testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled, failed - failure(DuckDuckGo_Privacy_Browser.FileDownloadError.failedToCompleteDownloadTask(underlyingError: Optional(Timeout), resumeData: nil, isRetryable: false)) – Download task should‘ve been cancelled
|
Run integration tests:
IntegrationTests/History/HistoryIntegrationTests.swift#L219
testWhenScriptTrackerLoaded_trackerAddedToHistory, failed: caught error: "Timeout"
|
Upload failed unit tests xcresult
No files were found with the provided path: Non-Sandbox-unittests.xcresult. No artifacts will be uploaded.
|
Run integration tests
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
Build and run unit tests:
LocalPackages/XPCHelper/Sources/XPCHelper/XPCServer.swift#L56
capture of 'newConnection' with non-sendable type 'NSXPCConnection' in a `@Sendable` closure; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/UDSHelper/Sources/UDSHelper/UDSServer.swift#L25
extension declares a conformance of imported type 'NWConnection' to imported protocols 'Hashable', 'Equatable'; this will not behave correctly if the owners of 'Network' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/AppKitExtensions/Sources/AppKitExtensions/NSEventExtension.swift#L118
extension declares a conformance of imported type 'Set' to imported protocols 'ExpressibleByStringLiteral', 'ExpressibleByExtendedGraphemeClusterLiteral', 'ExpressibleByUnicodeScalarLiteral'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L179
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L173
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L326
global actor 'UDPFlowActor'-isolated instance method 'hash(into:)' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionProxy/FlowManagers/UDPFlowManager.swift#L322
global actor 'UDPFlowActor'-isolated operator function '==' cannot be used to satisfy nonisolated protocol requirement; this is an error in the Swift 6 language mode
|
Build and run unit tests:
LocalPackages/SubscriptionUI/Sources/SubscriptionUI/DebugMenu/DebugPurchaseView.swift#L167
extension declares a conformance of imported type 'String' to imported protocol 'Identifiable'; this will not behave correctly if the owners of 'Swift' introduce this conformance in the future
|
Build and run unit tests:
DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/NetworkProtectionTokenStore+SubscriptionTokenKeychainStorage.swift#L25
extension declares a conformance of imported type 'NetworkProtectionKeychainTokenStore' to imported protocol 'SubscriptionTokenStoring'; this will not behave correctly if the owners of 'NetworkProtection' introduce this conformance in the future
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testFeatureDisabledAndPhishingDetection_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetected_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenDDGLoaded_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedThenNotDetected_tabIsNotMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaHTTPRedirectChain_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingDetectedViaJSRedirectChain_tabIsMarkedPhishing
|
Run integration tests
Skipped Integration_Tests.MaliciousSiteProtectionIntegrationTests.testPhishingNotDetected_tabIsNotMarkedPhishing
|
Loading