Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate NetP with subscription #2359

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Integrate NetP with subscription #2359

merged 3 commits into from
Jan 24, 2024

Conversation

quanganhdo
Copy link
Member

Task/Issue URL: https://app.asana.com/0/1203137811378537/1204886111391114/f
Tech Design URL:
CC:

Description:

Integrates NetP flow with subscription.

Steps to test this PR:

  1. Go to Settings > Learn more (under Privacy Pro)
  2. Follow the subscription flow and buy a subscription
  3. You should have access to NetP
  4. Remove subscription from the device
  5. You should lose access to NetP
  6. Go back to the subscription flow and restore it
  7. Again NetP is back

Back end might currently have issues exchanging the token.

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@quanganhdo quanganhdo requested a review from samsymons January 19, 2024 16:31
# Conflicts:
#	DuckDuckGo/UserText.swift
#	DuckDuckGo/en.lproj/Localizable.strings
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the exchange issue we talked about offline. I'll file that separately and bring it up with the O-1 team.

@quanganhdo
Copy link
Member Author

To be followed-up when this is resolved: https://app.asana.com/0/0/1206435347856772/f

@quanganhdo quanganhdo merged commit 6c22f40 into main Jan 24, 2024
10 checks passed
@quanganhdo quanganhdo deleted the anh/netp-subscription branch January 24, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants