NetP feature usage pixels #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
graeme/add-wireguard-pixels
to
graeme/netp-error-pixels
September 21, 2023 11:22
graeme
force-pushed
the
graeme/add-netp-feature-usage-pixels
branch
from
f619d7c to
fb16b56
Compare
samsymons
reviewed
Sep 21, 2023
Comment on lines
+33
to
+39
| func expireRegistrationKeyNow() async { | ||
| guard let activeSession = try? await ConnectionSessionUtilities.activeSession() else { | ||
| return | ||
| } | ||
|
|
||
| try? activeSession.sendProviderMessage(.expireRegistrationKey) | ||
| } |
samsymons
reviewed
Sep 21, 2023
| @@ -63,6 +66,12 @@ final class NetworkProtectionDebugViewController: UITableViewController { | |||
|
|
|||
| } | |||
|
|
|||
| enum RegistrationKeyRows: Int, CaseIterable { | |||
|
|
|||
| case expireNow | |||
There was a problem hiding this comment.
In the future we could add last rekey date here, so it's easy to see how well this is working in real-world scenarios, but we don't need to do it here. We have a project dedicated to the debug menu which tbh I would like to break up into tasks, so it can be done as a part of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205537962077888/f
Description:
Pixels for determining performance and how often users are using the VPN.
m_netp_daily_active_dm_netp_latencylatency: An integer value representing the user's latency in millisecondsserver: The identifier of the server, taken from the NetP server listnetwork_type: The user's network type (one of cell, wifi, eth)m_netp_rekey_completedSteps to test this PR:
Pixel.fire(pixelNamed…function at L: 203Copy Testing:
’rather than’Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template