Skip to content

Commit

Permalink
Don't report CancellationError from BookmarksFaviconsFetcher (#2385)
Browse files Browse the repository at this point in the history
Task/Issue URL: https://app.asana.com/0/1201493110486074/1206407973669779/f

Description:
Keep cancelling operations when requested, but without reporting the cancellation
to errorEvents, which could have caused them being reported as Pixels.
  • Loading branch information
ayoy authored Jan 26, 2024
1 parent eb90ec6 commit 7c96384
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion DuckDuckGo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -9978,7 +9978,7 @@
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
requirement = {
kind = exactVersion;
version = 102.0.1;
version = 102.0.2;
};
};
C14882EB27F211A000D59F0C /* XCRemoteSwiftPackageReference "SwiftSoup" */ = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/DuckDuckGo/BrowserServicesKit",
"state" : {
"revision" : "93fa38a7412fd665ed2f72df0fd26f69e61c9fe1",
"version" : "102.0.1"
"revision" : "072df96b846e3350b23ab32a61b6c1a0983b5e85",
"version" : "102.0.2"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion LocalPackages/DuckUI/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ let package = Package(
targets: ["DuckUI"])
],
dependencies: [
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "102.0.1"),
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "102.0.2"),
],
targets: [
.target(
Expand Down
2 changes: 1 addition & 1 deletion LocalPackages/SyncUI/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ let package = Package(
],
dependencies: [
.package(path: "../DuckUI"),
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "102.0.1"),
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "102.0.2"),
.package(url: "https://github.com/duckduckgo/DesignResourcesKit", exact: "2.0.0")
],
targets: [
Expand Down
2 changes: 1 addition & 1 deletion LocalPackages/Waitlist/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ let package = Package(
targets: ["Waitlist", "WaitlistMocks"])
],
dependencies: [
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "102.0.1"),
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "102.0.2"),
.package(url: "https://github.com/duckduckgo/DesignResourcesKit", exact: "2.0.0")
],
targets: [
Expand Down

0 comments on commit 7c96384

Please sign in to comment.