Skip to content

Commit

Permalink
Do not notify the FE on experiment activation (#3450)
Browse files Browse the repository at this point in the history
<!--
Note: This checklist is a reminder of our shared engineering
expectations. Feel free to change it, although assigning a GitHub
reviewer and the items in bold are required.

⚠️ If you're an external contributor, please file an issue first before
working on a PR, as we can't guarantee that we will accept your changes
if they haven't been discussed ahead of time. Thanks!
-->

Task/Issue URL:
https://app.asana.com/0/1204099484721401/1208531438887018/f

**Description**:
- Mitigates Frontend issue causing DuckPlayer to be stuck in Youtube
Mode
  • Loading branch information
afterxleep authored Oct 17, 2024
1 parent 5a47525 commit 44de886
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions DuckDuckGo/DuckPlayer/DuckPlayerNavigationHandler.swift
Original file line number Diff line number Diff line change
Expand Up @@ -228,15 +228,15 @@ final class DuckPlayerNavigationHandler {
// Enroll user if not enrolled
if !experiment.isEnrolled {
experiment.assignUserToCohort()
}

// DuckPlayer is disabled before user enrolls,
// So trigger a settings change notification
// to let the FE know about the 'actual' setting
// and update Experiment value
if experiment.isExperimentCohort {
duckPlayer.settings.triggerNotification()
experiment.duckPlayerMode = duckPlayer.settings.mode
// DuckPlayer is disabled before user enrolls,
// So trigger a settings change notification
// to let the FE know about the 'actual' setting
// and update Experiment value
if experiment.isExperimentCohort {
duckPlayer.settings.triggerNotification()
experiment.duckPlayerMode = duckPlayer.settings.mode
}
}

experiment.fireYoutubePixel(videoID: videoID)
Expand Down

0 comments on commit 44de886

Please sign in to comment.