Shared code for VPN onboarding tips #1024
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2024
diegoreymendez
changed the title
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Oct 28, 2024
Task/Issue URL: https://app.asana.com/0/1206580121312550/1208341440402810/f macOS PR: duckduckgo/macos-browser#3410 BSK PR: duckduckgo/BrowserServicesKit#1024 ## Description Shows VPN onboarding tips.
samsymons
reviewed
Nov 28, 2024
| @@ -0,0 +1,36 @@ | |||
| // The Swift Programming Language | |||
| // https://docs.swift.org/swift-book | |||
There was a problem hiding this comment.
This will need to be swapped to use the project-wide header comment
samsymons
reviewed
Nov 28, 2024
Comment on lines
+89
to
+93
| @available(iOS 17.0, *) | ||
| public func resetTipKitOnNextAppLaunch() { | ||
| resetTipKitOnNextLaunch = true | ||
| logger.debug("TipKit will reset on next app launch") | ||
| } |
There was a problem hiding this comment.
Is it intended that this is only checking for an iOS version? (I think so, but just double checking)
samsymons
approved these changes
Nov 28, 2024
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Nov 28, 2024
Task/Issue URL: https://app.asana.com/0/1206580121312550/1208795272851000/f iOS PR: duckduckgo/iOS#3429 BSK PR: duckduckgo/BrowserServicesKit#1024 ## Description Shows VPN onboarding tips.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208360455128593/f
iOS PR: duckduckgo/iOS#3429
macOS PR: duckduckgo/macos-browser#3410
What kind of version bump will this require?: Major
Description:
Implements multiplatform utility code for TipKit support.
Testing
See platform specific PRs for testing instructions.
Internal references:
Software Engineering Expectations
Technical Design Template