Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to build failure for duckdb_wasm sub-project test #1890

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ritalin
Copy link

@ritalin ritalin commented Oct 10, 2024

Description

This is PR for issue #1888.
A test for duckdb_wasm sub-project has failed to build.
It resolves this issue.

Details

To build test artifact is success, but executing test still fails.
Following testcases:

AllTypesTest.FullRangeTypes

This test is used a udf test_all_types.
It fails to not match expects columns with test_all_types columns.
I've fixed SUPPORTED_TYPES variable.

ParquetLoadTest.LoadParquet

In 1.29.0, DuckDB extensions support enabled by default.
So calling duckdb_web_parquet_init(&db->database()) failes.
I've fixed this line.

Same for the following:

  • ParquetLoadTest.LoadParquetTwice
  • FileSystemBufferTest.FlushFrameMemoryBugRegression
  • WebFileSystemTest.LoadParquet

CSVExportTest.TestExport

This test fails calling WebDB::Connection::InsertCSVFromPath.

{"exception_type":"Not implemented","exception_message":"Unsupported compression type for default file system"}

But this method does not have a compression option.
It makes no sense for me.

EDIT:
This test case is created WebDB with NATIVE mode.
A NATIVE uses duckdb::LocalFileSystem as the filesystem.
It seems that duckdb::LocalFileSystem does not support duckdb::FileCompressionType::AUTO_DETECT.
I've fixed WebTag to WEB.

FilePageBufferTest.FixSingle

It fails calling TestableFilePageBuffer::BuffersFile after FilePageBuffer::FileRef::Release.
It seems that accessing released file buffer is incorrect.

Passing false as FilePageBuffer::FileRef::Release argument led to close properly.
So I've fixed passing to false.


And a artifact on built in debug mode let to be address sanitizer errors.
I can not resolve it.
A work around is built on release mode.

@ritalin
Copy link
Author

ritalin commented Oct 10, 2024

I can include the fixes AllTypesTest.FullRangeTypes and ParquetLoadTest.LoadParquet this PR.
What do you think?

I've fixed it so that all test green !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant