Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caching issues #19

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Fix caching issues #19

merged 4 commits into from
Jan 31, 2024

Conversation

samansmink
Copy link
Collaborator

@domoritz
Copy link

Is there anything left here. It would be nice to get this in so we can update duckdb in mosaic (uwdata/mosaic#215).

@mingfang
Copy link

please merge

@jheer
Copy link

jheer commented Jan 27, 2024

Would love to see progress here. The node.js client with arrow extension is currently unusable with some queries. If fixed we can update the Mosaic project to the latest DuckDB and provide server-side access to the latest features. Thank you!!

@samansmink
Copy link
Collaborator Author

Apologies for neglecting things here, the arrow extension is quite low on our very full priorities list atm. If you feel like this is unjustified, please ping me or @hannes

I will make an effort to get the arrow extension ready for the upcoming v0.10 by fixing ci here and merging this

@jheer
Copy link

jheer commented Jan 30, 2024

Thank you @samansmink! I'm sure prioritization must be tricky given the large surface area of extensions and clients in addition to the DuckDB core. I also understand that data analysts/engineers working in Python or R may be a bigger audience right now. That said, I'd still put in a strong plug for a high-quality JS client which, alongside DuckDB-WASM, provides a solid base for developing DuckDB-powered web applications in JavaScript.

In this specific case, the bugs effectively make working with the node client and using Arrow for efficient transfer impossible for certain (in our case, common) queries. So I hope the severity of the issue also helps influence priorities for both fixes and test coverage.

In any case, thanks again. The DuckDB ecosystem is enabling exciting new possibilities and I appreciate the team's efforts.

@samansmink samansmink merged commit 0541721 into duckdb:main Jan 31, 2024
16 checks passed
@samansmink samansmink deleted the fix-caching-issues branch January 31, 2024 13:42
@domoritz
Copy link

Thank you for making time for this fix @samansmink!

@jheer
Copy link

jheer commented Jan 31, 2024

Thanks @samansmink!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nodejs] arrowIPCAll crashes on a query with UNION ALL and ORDER BY
4 participants