Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes/validation #14

Merged
merged 10 commits into from
Mar 5, 2024
Merged

Fixes/validation #14

merged 10 commits into from
Mar 5, 2024

Conversation

pkly
Copy link
Member

@pkly pkly commented Mar 5, 2024

Rework slightly how validation is done in bundle to allow context to be validated correctly in most cases.

Copy link

github-actions bot commented Mar 5, 2024

Code Coverage

Package Line Rate Health
ArgumentResolver/DtoArgumentResolver.php 100%
Attributes/Dto/AllowEnum.php 100%
Attributes/Dto/Bag.php 100%
Attributes/Dto/FindBy.php 91%
Attributes/Dto/FindComplex.php 0%
Attributes/Dto/FindOneBy.php 100%
Attributes/Dto/Format.php 100%
Attributes/Dto/FromKey.php 100%
Attributes/Dto/Http/OnNull.php 0%
Attributes/Dto/Path.php 100%
Attributes/Dto/ProvideValidationGroups.php 100%
Attributes/Dto/Type.php 100%
Attributes/Entity/EntityProvider.php 100%
Constraints/ArrayAll.php 0%
Constraints/ArrayAllValidator.php 100%
Constraints/MappedToPath.php 100%
Constraints/MappedToPathValidator.php 86%
Constraints/ObjectCollection.php 0%
Constraints/ObjectCollectionValidator.php 0%
DependencyInjection/DtoExtension.php 100%
DependencyInjection/Entity/CompilerPass/ComplexLoaderCompilerPass.php 100%
DependencyInjection/Entity/CompilerPass/DoctrineRepositoryCompilerPass.php 100%
DependencyInjection/Entity/CompilerPass/LabelProcessorCompilerPass.php 100%
DependencyInjection/Entity/CompilerPass/ProviderServiceCompilerPass.php 98%
DependencyInjection/Shared/CompilerPass/RemoveSpecificTagCompilerPass.php 100%
DependencyInjection/Shared/TaggingExtension.php 100%
DependencyInjection/Validation/CompilerPass/ValidationGroupAddingCompilerPass.php 100%
DtoBundle.php 100%
Enum/BagEnum.php 100%
Event/DtoResolvedEvent.php 100%
EventSubscriber/HttpDtoActionSubscriber.php 100%
Exception/DependencyInjection/Entity/AttributeMissingException.php 100%
Exception/DependencyInjection/Entity/DuplicateDefaultProviderException.php 100%
Exception/Dynamic/ParameterNotAvailableException.php 0%
Exception/Dynamic/ParameterNotSupportedException.php 0%
Exception/Entity/ComplexLoaderFunctionNotFoundException.php 0%
Exception/Entity/ComplexLoaderNotFoundException.php 0%
Exception/Entity/CustomProviderNotFoundException.php 0%
Exception/Entity/DefaultProviderNotFoundException.php 0%
Exception/Entity/EntityHasNoProviderException.php 0%
Exception/Entity/LabelProcessorNotFoundException.php 0%
Exception/Entity/ProviderNotFoundException.php 0%
Exception/Http/DtoHttpException.php 50%
Exception/Type/InvalidDateTimeClassException.php 0%
Exception/Type/InvalidTypeCountException.php 0%
Interfaces/Attribute/DtoAttributeInterface.php 0%
Interfaces/Attribute/FieldInterface.php 0%
Interfaces/Attribute/FindComplexInterface.php 0%
Interfaces/Attribute/FindInterface.php 0%
Interfaces/Attribute/HttpActionInterface.php 0%
Interfaces/Attribute/PathInterface.php 0%
Interfaces/Attribute/ProvidedInterface.php 0%
Interfaces/DtoInterface.php 0%
Interfaces/Dynamic/ResolverInterface.php 0%
Interfaces/Dynamic/ResolverServiceInterface.php 0%
Interfaces/Entity/ComplexLoaderInterface.php 0%
Interfaces/Entity/ComplexLoaderServiceInterface.php 0%
Interfaces/Entity/LabelProcessorInterface.php 0%
Interfaces/Entity/LabelProcessorServiceInterface.php 0%
Interfaces/Entity/ProviderInterface.php 0%
Interfaces/Entity/ProviderServiceInterface.php 0%
Interfaces/Entity/TargetProviderInterface.php 0%
Interfaces/Http/ActionValidatorInterface.php 0%
Interfaces/Resolver/DtoResolverInterface.php 0%
Interfaces/Resolver/DtoTypeExtractorInterface.php 0%
Interfaces/Type/CoercerInterface.php 0%
Interfaces/Type/CoercionServiceInterface.php 0%
Interfaces/Validation/GroupProviderInterface.php 0%
Interfaces/Validation/GroupServiceInterface.php 0%
Interfaces/Validation/TypeValidationInterface.php 0%
Model/AbstractDto.php 87%
Model/Type/CoerceResult.php 100%
Model/Type/Dto.php 0%
Model/Type/Property.php 83%
Profiler/AbstractWrapper.php 64%
Profiler/Service/Entity/ProfilingEntityProviderService.php 100%
Profiler/Service/Resolver/ProfilingDtoResolverService.php 100%
Profiler/Service/Resolver/ProfilingDtoTypeExtractorService.php 100%
Profiler/Service/Validation/ProfilingTypeValidationService.php 100%
Service/Entity/ComplexLoaderService.php 100%
Service/Entity/EntityProviderService.php 100%
Service/Entity/LabelProcessor/DefaultProcessor.php 100%
Service/Entity/LabelProcessor/PascalCaseProcessor.php 100%
Service/Entity/LabelProcessorService.php 43%
Service/Entity/TargetProviderService.php 89%
Service/Http/ActionValidatorService.php 44%
Service/Http/OnNullActionValidator.php 100%
Service/Nelmio/DtoOADescriber.php 54%
Service/Resolver/DtoResolverService.php 92%
Service/Resolver/DtoTypeExtractorHelper.php 93%
Service/Resolver/DynamicResolverService.php 100%
Service/Type/Coercer/BoolCoercer.php 88%
Service/Type/Coercer/DateTimeImmutableCoercer.php 77%
Service/Type/Coercer/EnumCoercer.php 94%
Service/Type/Coercer/FloatCoercer.php 100%
Service/Type/Coercer/IntCoercer.php 100%
Service/Type/Coercer/StringCoercer.php 100%
Service/Type/Coercer/UploadedFileCoercer.php 100%
Service/Type/CoercerService.php 100%
Service/Validation/GroupProviderService.php 86%
Service/Validation/TypeValidationHelper.php 92%
Traits/Annotation/FieldTrait.php 91%
Traits/Annotation/HttpActionTrait.php 80%
Traits/Annotation/LimitAndOffsetTrait.php 0%
Traits/Annotation/PathTrait.php 100%
Traits/Annotation/ProviderTrait.php 100%
Traits/Type/CoerceConstructWithValidatorTrait.php 100%
Traits/Type/CoercerResultTrait.php 96%
Util.php 100%
Summary 84% (1064 / 1271)

Minimum allowed line rate is 70%

1 similar comment
Copy link

github-actions bot commented Mar 5, 2024

Code Coverage

Package Line Rate Health
ArgumentResolver/DtoArgumentResolver.php 100%
Attributes/Dto/AllowEnum.php 100%
Attributes/Dto/Bag.php 100%
Attributes/Dto/FindBy.php 91%
Attributes/Dto/FindComplex.php 0%
Attributes/Dto/FindOneBy.php 100%
Attributes/Dto/Format.php 100%
Attributes/Dto/FromKey.php 100%
Attributes/Dto/Http/OnNull.php 0%
Attributes/Dto/Path.php 100%
Attributes/Dto/ProvideValidationGroups.php 100%
Attributes/Dto/Type.php 100%
Attributes/Entity/EntityProvider.php 100%
Constraints/ArrayAll.php 0%
Constraints/ArrayAllValidator.php 100%
Constraints/MappedToPath.php 100%
Constraints/MappedToPathValidator.php 86%
Constraints/ObjectCollection.php 0%
Constraints/ObjectCollectionValidator.php 0%
DependencyInjection/DtoExtension.php 100%
DependencyInjection/Entity/CompilerPass/ComplexLoaderCompilerPass.php 100%
DependencyInjection/Entity/CompilerPass/DoctrineRepositoryCompilerPass.php 100%
DependencyInjection/Entity/CompilerPass/LabelProcessorCompilerPass.php 100%
DependencyInjection/Entity/CompilerPass/ProviderServiceCompilerPass.php 98%
DependencyInjection/Shared/CompilerPass/RemoveSpecificTagCompilerPass.php 100%
DependencyInjection/Shared/TaggingExtension.php 100%
DependencyInjection/Validation/CompilerPass/ValidationGroupAddingCompilerPass.php 100%
DtoBundle.php 100%
Enum/BagEnum.php 100%
Event/DtoResolvedEvent.php 100%
EventSubscriber/HttpDtoActionSubscriber.php 100%
Exception/DependencyInjection/Entity/AttributeMissingException.php 100%
Exception/DependencyInjection/Entity/DuplicateDefaultProviderException.php 100%
Exception/Dynamic/ParameterNotAvailableException.php 0%
Exception/Dynamic/ParameterNotSupportedException.php 0%
Exception/Entity/ComplexLoaderFunctionNotFoundException.php 0%
Exception/Entity/ComplexLoaderNotFoundException.php 0%
Exception/Entity/CustomProviderNotFoundException.php 0%
Exception/Entity/DefaultProviderNotFoundException.php 0%
Exception/Entity/EntityHasNoProviderException.php 0%
Exception/Entity/LabelProcessorNotFoundException.php 0%
Exception/Entity/ProviderNotFoundException.php 0%
Exception/Http/DtoHttpException.php 50%
Exception/Type/InvalidDateTimeClassException.php 0%
Exception/Type/InvalidTypeCountException.php 0%
Interfaces/Attribute/DtoAttributeInterface.php 0%
Interfaces/Attribute/FieldInterface.php 0%
Interfaces/Attribute/FindComplexInterface.php 0%
Interfaces/Attribute/FindInterface.php 0%
Interfaces/Attribute/HttpActionInterface.php 0%
Interfaces/Attribute/PathInterface.php 0%
Interfaces/Attribute/ProvidedInterface.php 0%
Interfaces/DtoInterface.php 0%
Interfaces/Dynamic/ResolverInterface.php 0%
Interfaces/Dynamic/ResolverServiceInterface.php 0%
Interfaces/Entity/ComplexLoaderInterface.php 0%
Interfaces/Entity/ComplexLoaderServiceInterface.php 0%
Interfaces/Entity/LabelProcessorInterface.php 0%
Interfaces/Entity/LabelProcessorServiceInterface.php 0%
Interfaces/Entity/ProviderInterface.php 0%
Interfaces/Entity/ProviderServiceInterface.php 0%
Interfaces/Entity/TargetProviderInterface.php 0%
Interfaces/Http/ActionValidatorInterface.php 0%
Interfaces/Resolver/DtoResolverInterface.php 0%
Interfaces/Resolver/DtoTypeExtractorInterface.php 0%
Interfaces/Type/CoercerInterface.php 0%
Interfaces/Type/CoercionServiceInterface.php 0%
Interfaces/Validation/GroupProviderInterface.php 0%
Interfaces/Validation/GroupServiceInterface.php 0%
Interfaces/Validation/TypeValidationInterface.php 0%
Model/AbstractDto.php 87%
Model/Type/CoerceResult.php 100%
Model/Type/Dto.php 0%
Model/Type/Property.php 83%
Profiler/AbstractWrapper.php 64%
Profiler/Service/Entity/ProfilingEntityProviderService.php 100%
Profiler/Service/Resolver/ProfilingDtoResolverService.php 100%
Profiler/Service/Resolver/ProfilingDtoTypeExtractorService.php 100%
Profiler/Service/Validation/ProfilingTypeValidationService.php 100%
Service/Entity/ComplexLoaderService.php 100%
Service/Entity/EntityProviderService.php 100%
Service/Entity/LabelProcessor/DefaultProcessor.php 100%
Service/Entity/LabelProcessor/PascalCaseProcessor.php 100%
Service/Entity/LabelProcessorService.php 43%
Service/Entity/TargetProviderService.php 89%
Service/Http/ActionValidatorService.php 44%
Service/Http/OnNullActionValidator.php 100%
Service/Nelmio/DtoOADescriber.php 54%
Service/Resolver/DtoResolverService.php 92%
Service/Resolver/DtoTypeExtractorHelper.php 93%
Service/Resolver/DynamicResolverService.php 100%
Service/Type/Coercer/BoolCoercer.php 88%
Service/Type/Coercer/DateTimeImmutableCoercer.php 77%
Service/Type/Coercer/EnumCoercer.php 94%
Service/Type/Coercer/FloatCoercer.php 100%
Service/Type/Coercer/IntCoercer.php 100%
Service/Type/Coercer/StringCoercer.php 100%
Service/Type/Coercer/UploadedFileCoercer.php 100%
Service/Type/CoercerService.php 100%
Service/Validation/GroupProviderService.php 86%
Service/Validation/TypeValidationHelper.php 92%
Traits/Annotation/FieldTrait.php 91%
Traits/Annotation/HttpActionTrait.php 80%
Traits/Annotation/LimitAndOffsetTrait.php 0%
Traits/Annotation/PathTrait.php 100%
Traits/Annotation/ProviderTrait.php 100%
Traits/Type/CoerceConstructWithValidatorTrait.php 100%
Traits/Type/CoercerResultTrait.php 96%
Util.php 100%
Summary 84% (1064 / 1271)

Minimum allowed line rate is 70%

@pkly pkly merged commit ba9c72e into master Mar 5, 2024
6 checks passed
@pkly pkly deleted the fixes/validation branch March 5, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant