Add timestamps for address book entries #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmihai
force-pushed
the
address-order-by-date
branch
4 times, most recently
from
aac7832
to
ee83fb2
Compare
castarco
reviewed
May 7, 2019
castarco
reviewed
May 7, 2019
castarco
reviewed
May 7, 2019
castarco
reviewed
May 7, 2019
scravy
reviewed
May 7, 2019
castarco
reviewed
May 7, 2019
This commit extends the `CAddressBookData` structure with a new field, `timestamp`, representing the creation or modification time of the address. It also adds a new argument to the `filteraddresses` RPC call, which allows sorting by the timestamp field, either in ascending or descending order. Required for implementing dtr-org/unit-e-desktop#57. Signed-off-by: Mihai Ciumeica <[email protected]>
Signed-off-by: Mihai Ciumeica <[email protected]>
Signed-off-by: Mihai Ciumeica <[email protected]>
Signed-off-by: Mihai Ciumeica <[email protected]>
Signed-off-by: Mihai Ciumeica <[email protected]>
Signed-off-by: Mihai Ciumeica <[email protected]>
Signed-off-by: Mihai Ciumeica <[email protected]>
cmihai
force-pushed
the
address-order-by-date
branch
from
9a94bfe
to
d44f2a1
Compare
Gnappuraz
approved these changes
May 8, 2019
castarco
reviewed
May 8, 2019
| self.extra_args = [[]] * 4 | ||
| self.extra_args[0] = ['-deprecatedrpc=accounts'] | ||
| self.extra_args = [['-mocktime=1500000000']] * 4 | ||
| self.extra_args[0] += ['-deprecatedrpc=accounts'] |
There was a problem hiding this comment.
nit: When appending one single element, it's better to rely on append than on extend:
self.extra_args[0].append('-deprecatedrpc=accounts')Although it's also OK as it is now.
castarco
approved these changes
May 8, 2019
cmihai
force-pushed
the
address-order-by-date
branch
from
2c0a0ed
to
d44f2a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extends the
CAddressBookDatastructure with a new field,timestamp, representing the time when a Unit-e address was created or modified.It also adds a new argument to the
filteraddressesRPC call, which allowssorting by the timestamp field, either in ascending or descending order.
Required for sorting addresses by date in a desktop wallet.