Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable toml "parse" feature #22

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Disable toml "parse" feature #22

merged 1 commit into from
Nov 12, 2024

Conversation

dtolnay
Copy link
Owner

@dtolnay dtolnay commented Nov 12, 2024

The toml dependency is only used for serializing --config flags.

cargo-docs-rs/src/main.rs

Lines 219 to 221 in d1368f6

let rustflags = toml::Value::try_from(&rustflags).unwrap();
cargo_rustdoc.flag_value("--config", format!("build.rustflags={}", rustflags));
cargo_rustdoc.flag_value("--config", format!("host.rustflags={}", rustflags));

We do not need support for parsing TOML in this crate.

Before:

$ cargo tree -e features -i toml
toml v0.8.19
├── toml feature "default"
│   └── cargo-docs-rs v0.1.13 (/git/cargo-docs-rs)
│       └── cargo-docs-rs feature "default" (command-line)
├── toml feature "display"
│   └── toml feature "default" (*)
└── toml feature "parse"
    └── toml feature "default" (*)

After:

$ cargo tree -e features -i toml
toml v0.8.19
└── toml feature "display"
    └── cargo-docs-rs v0.1.13 (/git/cargo-docs-rs)
        └── cargo-docs-rs feature "default" (command-line)

@dtolnay dtolnay merged commit de137d5 into master Nov 12, 2024
11 checks passed
@dtolnay dtolnay deleted the tomldisplay branch November 12, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant