Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale fix #29

Merged
merged 10 commits into from
Sep 5, 2024
Merged

Locale fix #29

merged 10 commits into from
Sep 5, 2024

Conversation

icicel
Copy link
Contributor

@icicel icicel commented Sep 4, 2024

Attempted to fix the language switcher. This involved "refreshing" (migrating) the database before deploying and generating some missing localization files.

Copy link
Contributor

@Multipacker Multipacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't gotten it to build yet but let's start here

Makefile Outdated
Comment on lines 30 to 34
build:
sudo -E docker-compose build

down:
sudo -E docker-compose down
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two are referred to in the README, so it should be updated with new build instructions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also just revert the change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also works

Copy link
Contributor

@The1Penguin The1Penguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good, if the answers are nice, then just go ahead

CMD ["uwsgi", "--socket", "0.0.0.0:3000", \
"--protocol", "uwsgi", \
"--module", "dtekportal.wsgi"]
CMD python3 manage.py migrate && python3 manage.py compilemessages && uwsgi --socket 0.0.0.0:3000 --protocol uwsgi --module dtekportal.wsgi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit funky, but it works

@@ -0,0 +1,5 @@
#!/usr/bin/env sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed for when developing and checking that it works in docker

@@ -2,6 +2,7 @@ __pycache__
secret-key.txt
portal-env
*.swp
*.mo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring compiled localization files

Copy link
Contributor

@malmz malmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ser okej ut

Copy link
Contributor

@Multipacker Multipacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@The1Penguin The1Penguin merged commit 50fa8fe into main Sep 5, 2024
1 check passed
@icicel icicel deleted the locale-fix branch September 5, 2024 16:43
@icicel icicel restored the locale-fix branch September 5, 2024 16:43
@icicel icicel deleted the locale-fix branch September 5, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants