Fixes to Distribution History and Link Distribution #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added wrapper logic to retry if there are api failures
added wrapper to retry if there are api failures
Added the link distribution part back in fixed distributionId column name added Messages before each api call to distinguish the distribution history call from the link distribution call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The api retry stuff may be a bit heavy-handed for ultimate inclusion in the package. IMO it needs to be in there, in some form-- but perhaps a less "chatty" version.
Fixed distributionId column name
Added the links call back to the history function. I've tested this myself on a distribution with 30000 emails and it works well.