Add extension for Sequel transactions #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for #22 |
waiting-for-dev
force-pushed
the
waiting-for-dev/sequel
branch
from
be0e182
to
c74658a
Compare
|
Setting back to draft as we'll need to apply changes as in #24 |
waiting-for-dev
force-pushed
the
waiting-for-dev/sequel
branch
2 times, most recently
from
4eb7232
to
305c248
Compare
We add a `Dry::Operation::Extensions::Sequel` module that, when included, gives access to a `#transaction` method. This method wraps the yielded steps in a [Sequel](https://sequel.jeremyevans.net/) transaction, rolling back in case one of them returns a failure. The extension expects the including class to define a `#db` method giving access to the Sequel database definition: ```ruby class MyOperation < Dry::Operation include Dry::Operation::Extensions::Sequel attr_reader :db def initialize(db:) @db = db end def call(input) attrs = step validate(input) user = transaction do new_user = step persist(attrs) step assign_initial_role(new_user) new_user end step notify(user) user end # ... end ``` Default options for the `#transaction` options (which delegates to Sequel [transaction method](https://sequel.jeremyevans.net/rdoc/files/doc/transactions_rdoc.html)) can be given both at include time with `include Dry::Operation::Extensions::Sequel[isolation: :serializable]`, and at runtime with `#transaction(isolation: :serializable)`. As with the ActiveRecord extension, savepoints on nested transactions are not supported yet
waiting-for-dev
force-pushed
the
waiting-for-dev/sequel
branch
from
305c248
to
4195339
Compare
|
Applying changes as in #25 |
timriley
approved these changes
Oct 27, 2024
| @@ -156,7 +156,7 @@ def initialize(model) | |||
| def call | |||
| transaction do | |||
| step create_record | |||
| transaction(requires_new: true) do | |||
There was a problem hiding this comment.
Was this change intended to be part of this PR? It's a test for AR, not Sequel.
There was a problem hiding this comment.
My bad, not sure how but I confused AR and Sequel options in the tests
| instance.() | ||
| end | ||
|
|
||
| xit "works with `requires_new` for nested transactions" do |
There was a problem hiding this comment.
Is requires_new also a Sequel thing? I recall seeing this skipped test from the AR extension... is it a copy/paste mistake?
There was a problem hiding this comment.
Same... Sequel uses savepoint. Fixed. Thanks for spotting it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We add a
Dry::Operation::Extensions::Sequelmodule that, when included, gives access to a#transactionmethod. This method wraps the yielded steps in a Sequel transaction, rolling back in case one of them returns a failure.The extension expects the including class to define a
#dbmethod giving access to the Sequel database definition:Default options for the
#transactionoptions (which delegates to Sequel transaction method) can be given both at include time withinclude Dry::Operation::Extensions::Sequel[isolation: :serializable], and at runtime with#transaction(isolation: :serializable).As with the ActiveRecord extension, savepoints on nested transactions are not supported yet
Screenshots/Screencasts
Details