Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Social Auth #8

Open
wants to merge 43 commits into
base: 8.x-2.x
Choose a base branch
from
Open

Add tests for Social Auth #8

wants to merge 43 commits into from

Conversation

neerajp99
Copy link
Member

No description provided.

@neerajp99 neerajp99 changed the title Add tests for class AuthManager and AuthManagerInterface Add tests for Social Auth Jun 6, 2019
@gvso
Copy link
Contributor

gvso commented Jun 15, 2019 •
edited
Loading

I didn't even look at the code thoroughly. Just looking at 10 lines of the changes gave me the idea that you're not following all my recommendations nor running code sniffer.

neerajp99 and others added 16 commits June 16, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvso gvso gvso left review comments

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neerajp99 @gvso