Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added condition in graphql.install for non empty variable #1344

Open
wants to merge 3 commits into
base: 8.x-4.x
Choose a base branch
from

Conversation

aarohiprasad
Copy link

@aarohiprasad aarohiprasad commented Jul 4, 2023

Context:

  1. Install Drupal in (standard install profile)
  2. Install graphQL module
  3. Uninstall GraphQL module and see error
 ---- -------------- -------- ---------- -------------------------------------- 
  ID   Date           Type     Severity   Message                               
 ---- -------------- -------- ---------- -------------------------------------- 
  46   04/Jul 15:32   php      Error      TypeError: array_keys(): Argument #1  
                                          ($array) must be of type array, null  
                                          given in array_keys() (line 40 of     
                                          /var/www/html/web/modules/contrib/gr  
                                          aphql/graphql.install).   

This PR adds an 'if' condition in graphql.install to check if language module is correctly enabled

@aarohiprasad aarohiprasad marked this pull request as draft July 4, 2023 14:42
@aarohiprasad aarohiprasad marked this pull request as ready for review July 4, 2023 15:36
Copy link
Contributor

@Kingdutch Kingdutch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting this bug, I think we can make a more focused change though that more clearly communicates what is going wrong :D

graphql.install Outdated Show resolved Hide resolved
@darvanen
Copy link
Contributor

darvanen commented Oct 9, 2023

I also ran into this issue.

@kay-o
Copy link

kay-o commented Oct 15, 2024

I'm getting the same issue with the following versions installed with Drupal 10.3.6

"drupal/graphql": "4.x-dev@dev",
"drupal/graphql_compose": "^2.1",
"drupal/typed_data": "^1.0@beta",

Applying the changes in the first commit allowed me to uninstall the graphql module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants