Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support file_entity metadata for width/height #1276

Open
wants to merge 1 commit into
base: 8.x-4.x
Choose a base branch
from
Open

Support file_entity metadata for width/height #1276

wants to merge 1 commit into from

Conversation

Berdir
Copy link

@Berdir Berdir commented Apr 29, 2022

PR for suggested optimization when using file_entity for #1275

@klausi klausi added the 4.x label May 20, 2022
klausi
klausi reviewed May 20, 2022
View reviewed changes
Copy link
Contributor

@klausi klausi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me.

PHPStan complains because it cannot find file_entity module. Can you add it to the composer install list in testing.yml ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klausi klausi klausi left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
4.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Berdir @klausi